Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add copyright attribution and license to FileValues and expose on v2 api (DEV-4351) #3431

Merged
merged 10 commits into from
Nov 20, 2024
Merged

feat: Add copyright attribution and license to FileValues and expose on v2 api (DEV-4351) #3431

merged 10 commits into from
Nov 20, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 18, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title Add copyright and license to resource/fileValue feat: Add copyright and license to FileValues and expose on v2 api Nov 18, 2024
@seakayone seakayone changed the title feat: Add copyright and license to FileValues and expose on v2 api feat: Add copyright attribution and license to FileValues and expose on v2 api Nov 19, 2024
@seakayone seakayone changed the title feat: Add copyright attribution and license to FileValues and expose on v2 api feat: Add copyright attribution and license to FileValues and expose on v2 api (DEV-4351) Nov 19, 2024
@linear Linear
Copy link

linear bot commented Nov 19, 2024

DEV-4351 Add copyright and license to creating and updating `FileValue`s in dsp-api

@seakayone seakayone marked this pull request as ready for review November 19, 2024 15:36
@seakayone seakayone merged commit f9dcd98 into main Nov 20, 2024
9 checks passed
@seakayone seakayone deleted the feat/add-license-and-copyright-attribution-to-FileValues branch November 20, 2024 17:32
@daschbot daschbot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@siers siers Awaiting requested review from siers siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seakayone @mpro7