Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add license and copyright attribution to project (DEV-4346) #3429

Merged
merged 13 commits into from
Nov 18, 2024
Merged

feat: Add license and copyright attribution to project (DEV-4346) #3429

merged 13 commits into from
Nov 18, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 15, 2024 •
edited
Loading

  • feat: Add copyright attribution and license to Project and expose on the api for create and update

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title feat/add license and copyright attribution to projec feat/add license and copyright attribution to project (DEV-4347) Nov 15, 2024
@linear Linear
Copy link

linear bot commented Nov 15, 2024

DEV-4347 Add copyright and license to knora-base and knora-admin ontology

@seakayone seakayone changed the title feat/add license and copyright attribution to project (DEV-4347) feat: Add license and copyright attribution to project (DEV-4347) Nov 15, 2024
@seakayone seakayone self-assigned this Nov 15, 2024
@seakayone seakayone marked this pull request as ready for review November 15, 2024 16:26
mpro7
mpro7 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the other PR was merged before I reviewed it, but have general question related to property name, if it would make sense to shorten it to just copyright?

.../test/scala/org/knora/webapi/messages/admin/responder/IntegrationTestAdminJsonProtocol.scala Outdated Show resolved Hide resolved
@seakayone @mpro7
Update integration/src/test/scala/org/knora/webapi/messages/admin/res…
09df220 
…ponder/IntegrationTestAdminJsonProtocol.scala

Co-authored-by: Marcin Procyk <[email protected]>
@seakayone seakayone enabled auto-merge (squash) November 18, 2024 12:44
@seakayone
Copy link
Contributor Author

Unfortunately the other PR was merged before I reviewed it, but have general question related to property name, if it would make sense to shorten it to just copyright?

copyright attribution is what we decided to use a the term in the project.

@seakayone seakayone merged commit e51af72 into main Nov 18, 2024
9 checks passed
@seakayone seakayone deleted the feat/add-license-and-copyright-attribution-to-projec branch November 18, 2024 13:09
@daschbot daschbot mentioned this pull request Nov 15, 2024
Merged
@seakayone seakayone changed the title feat: Add license and copyright attribution to project (DEV-4347) feat: Add license and copyright attribution to project (DEV-4346) Nov 19, 2024
@linear Linear
Copy link

linear bot commented Nov 19, 2024

DEV-4346 Add copyright and license to admin project api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@siers siers Awaiting requested review from siers siers is a code owner

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seakayone @mpro7