chore: Add integration tests for project erasure (DEV-3681) #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seakayone
commented
Jun 17, 2024
seakayone
commented
- Inline OntologyResponderV2 trait and add test for deleting an ontology graph during project erasing
- Add test for administrative permissions
- Add test for daop cleanup
seakayone
changed the title
BalduinLandolt
approved these changes
Jun 18, 2024
siers
reviewed
Jun 18, 2024
.../scala/org/knora/webapi/slice/admin/repo/service/DefaultObjectAccessPermissionRepoLive.scala
Outdated
Show resolved
Hide resolved
siers
reviewed
Jun 18, 2024
...main/scala/org/knora/webapi/slice/admin/domain/model/DefaultObjectAccessPermissionRepo.scala
Outdated
Show resolved
Hide resolved
… into the companion object and extract fold method.
siers
approved these changes
Jun 18, 2024
siers
reviewed
Jun 18, 2024
| ) extends EntityWithId[PermissionIri] | ||
|
|
||
| object DefaultObjectAccessPermission { | ||
| enum ForWhat { |
There was a problem hiding this comment.
Wouldn't ForWhat be like a SubjectEntity or something? (Entity being sort of a stand-in for a tuple.)
There was a problem hiding this comment.
I also noticed that you named it after the forProject.
I guess you can resolve this and merge, if you so please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.