Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Separate ontology helpers accessing cache and triplestore #3270

Merged
merged 24 commits into from
Jun 10, 2024

remove unused import

90227ee
Select commit
Loading
Failed to load commit list.
Merged

refactor: Separate ontology helpers accessing cache and triplestore #3270

remove unused import
90227ee
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jun 10, 2024 in 0s

7 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 7
           

Clones added
============
- webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala  3
- webapi/src/main/scala/org/knora/webapi/responders/v2/OntologyResponderV2.scala  4
         

Clones removed
==============
+ webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyHelpers.scala  -3

See the complete overview on Codacy

Annotations

Check warning on line 127 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala#L127 

Method is longer than 50 lines.

Check warning on line 159 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala#L159 

Usage of get on optional type.

Check warning on line 194 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala#L194 

Usage of get on optional type.

Check warning on line 333 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyCacheHelpers.scala#L333 

Usage of get on optional type.

Check warning on line 94 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala#L94 

Method is longer than 50 lines.

Check notice on line 161 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala#L161 

Consider using case matching instead of else if blocks

Check notice on line 178 in webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/OntologyTriplestoreHelpers.scala#L178 

Consider using case matching instead of else if blocks
View more details on Codacy Production