Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Create resources repo #3269

Merged
merged 5 commits into from
Jun 6, 2024
Merged

refactor: Create resources repo #3269

merged 5 commits into from
Jun 6, 2024

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 14.02%. Comparing base (a622e4f) to head (0ea0c1b).
Report is 90 commits behind head on main.

Files Patch % Lines
...ice/resources/repo/service/ResourcesRepoLive.scala 0.00% 5 Missing ⚠️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% 2 Missing ⚠️
...ponders/v2/resources/CreateResourceV2Handler.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
+ Coverage   13.22%   14.02%   +0.80%     
==========================================
  Files         270      282      +12     
  Lines       22244    22937     +693     
==========================================
+ Hits         2941     3217     +276     
- Misses      19303    19720     +417     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review June 5, 2024 13:56
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fair enough.

@BalduinLandolt BalduinLandolt merged commit 351b3e0 into main Jun 6, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/more-refactoring branch June 6, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants