Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove MessageRelay from Value Responder #3268

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Jun 4, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (a622e4f) to head (d902c15).
Report is 89 commits behind head on main.

Files Patch % Lines
...knora/webapi/responders/v2/ValuesResponderV2.scala 84.61% 2 Missing ⚠️
...ponders/v2/resources/CreateResourceV2Handler.scala 97.18% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3268       +/-   ##
===========================================
+ Coverage   13.22%   83.59%   +70.37%     
===========================================
  Files         270      281       +11     
  Lines       22244    22934      +690     
===========================================
+ Hits         2941    19172    +16231     
+ Misses      19303     3762    -15541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review June 5, 2024 07:26
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BalduinLandolt BalduinLandolt merged commit 11e38a8 into main Jun 5, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/refactor-value-creation branch June 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants