Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add text value type to all new instances of TextValue (DEV-3721) #3267

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jun 4, 2024
Copy link

linear bot commented Jun 4, 2024

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 14.00%. Comparing base (a622e4f) to head (76dafb5).
Report is 90 commits behind head on main.

Current head 76dafb5 differs from pull request most recent head 1273aa9

Please upload reports for the commit 1273aa9 to get more accurate results.

Files Patch % Lines
...webapi/messages/util/ConstructResponseUtilV2.scala 0.00% 3 Missing ⚠️
...s/v2/responder/valuemessages/ValueMessagesV2.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   13.22%   14.00%   +0.77%     
==========================================
  Files         270      281      +11     
  Lines       22244    22991     +747     
==========================================
+ Hits         2941     3219     +278     
- Misses      19303    19772     +469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt deleted the feature/dev-3721-add-text-value-types-when-creatingupdating-text-value branch July 17, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant