refactor: Introduce OntologyService and refactor resource creation #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siers
approved these changes
May 29, 2024
| case Some(_: ApiV2Schema) => true | ||
| case _ => false | ||
| }) | ||
| iriInfo.iriType == KnoraDefinitionIri && iriInfo.ontologySchema.isInstanceOf[ApiV2Schema] |
There was a problem hiding this comment.
Is this precise? It's always going to be an instance of Option first, ApiV2Schema second. It's never a good idea to use isInstanceOf, it's not type safe, as you see here. If you're interested in the subtype, add WithAsIs and use .contains(_.is[ApiV2Schema]).
There was a problem hiding this comment.
right... that's actually not at all correct, I completely ignored the option. That may be the reason why suddenly all the tests fail.
There was a problem hiding this comment.
reverted the change which fixed the tests.
I don't think I want to spend anymore time on this PR, so I leave WithAsIs for another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?