Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sipi): Allow read all images for users with write:project:XXXX scope (DEV-2628) #3250

Merged
merged 6 commits into from
May 23, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 21, 2024

Pull Request Checklist

Task Description/Number

Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix.

This is necessary for the preview in dsp-app after the upload.

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone force-pushed the feat/allow-access-of-sipi-resources-for-project-admin branch 5 times, most recently from 3997da9 to 5b9d1d1 Compare May 21, 2024 13:09
@seakayone seakayone changed the title Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix (DEV-2628) May 21, 2024
@seakayone seakayone changed the title Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix (DEV-2628) feat(sipi): Allow read for project admin (DEV-2628) May 21, 2024
@seakayone seakayone self-assigned this May 21, 2024
@seakayone seakayone force-pushed the feat/allow-access-of-sipi-resources-for-project-admin branch 2 times, most recently from 2205ad7 to dc77aee Compare May 22, 2024 10:45
@seakayone seakayone force-pushed the feat/allow-access-of-sipi-resources-for-project-admin branch from dc77aee to 7529d04 Compare May 22, 2024 10:46
@seakayone seakayone changed the title feat(sipi): Allow read for project admin (DEV-2628) feat(sipi): Allow read all images for users with write:project:XXXX scope (DEV-2628) May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.96%. Comparing base (a622e4f) to head (2e93cd3).
Report is 74 commits behind head on main.

Current head 2e93cd3 differs from pull request most recent head 3a875fd

Please upload reports for the commit 3a875fd to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3250      +/-   ##
==========================================
+ Coverage   13.22%   13.96%   +0.74%     
==========================================
  Files         270      280      +10     
  Lines       22244    23089     +845     
==========================================
+ Hits         2941     3225     +284     
- Misses      19303    19864     +561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review May 22, 2024 13:03
@seakayone seakayone merged commit 9489ecd into main May 23, 2024
10 checks passed
@seakayone seakayone deleted the feat/allow-access-of-sipi-resources-for-project-admin branch May 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants