-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sipi): Allow read all images for users with write:project:XXXX scope (DEV-2628) #3250
Merged
seakayone
merged 6 commits into
main
from
feat/allow-access-of-sipi-resources-for-project-admin
May 23, 2024
Merged
feat(sipi): Allow read all images for users with write:project:XXXX scope (DEV-2628) #3250
seakayone
merged 6 commits into
main
from
feat/allow-access-of-sipi-resources-for-project-admin
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
force-pushed
the
feat/allow-access-of-sipi-resources-for-project-admin
branch
5 times, most recently
from
May 21, 2024 13:09
3997da9
to
5b9d1d1
Compare
seakayone
changed the title
Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix
Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix (DEV-2628)
May 21, 2024
seakayone
changed the title
Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix (DEV-2628)
feat(sipi): Allow read for project admin (DEV-2628)
May 21, 2024
seakayone
force-pushed
the
feat/allow-access-of-sipi-resources-for-project-admin
branch
2 times, most recently
from
May 22, 2024 10:45
2205ad7
to
dc77aee
Compare
seakayone
force-pushed
the
feat/allow-access-of-sipi-resources-for-project-admin
branch
from
May 22, 2024 10:46
dc77aee
to
7529d04
Compare
seakayone
changed the title
feat(sipi): Allow read for project admin (DEV-2628)
feat(sipi): Allow read all images for users with write:project:XXXX scope (DEV-2628)
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
==========================================
+ Coverage 13.22% 13.96% +0.74%
==========================================
Files 270 280 +10
Lines 22244 23089 +845
==========================================
+ Hits 2941 3225 +284
- Misses 19303 19864 +561 ☔ View full report in Codecov by Sentry. |
BalduinLandolt
approved these changes
May 22, 2024
mpro7
approved these changes
May 22, 2024
siers
approved these changes
May 22, 2024
seakayone
deleted the
feat/allow-access-of-sipi-resources-for-project-admin
branch
May 23, 2024 08:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Always allow access to resources in sipi if the access token is that of a system admin or project admin for the respective prefix.
This is necessary for the preview in dsp-app after the upload.
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?