Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set scalafix Scala 3 target dialect (DEV-3543) #3236

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: Set scalafix Scala 3 target dialect (DEV-3543) #3236

merged 1 commit into from
May 6, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 6, 2024 •
edited
Loading

  • chore: Set targetDialect in scalafix to Scala3

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the base branch from main to chore/scala3-compiler May 6, 2024 12:47
@seakayone seakayone changed the title chore: Set scalafix Scala 3 target dialect chore: Set scalafix Scala 3 target dialect (DEV-3543) May 6, 2024
@linear Linear
Copy link

linear bot commented May 6, 2024

DEV-3543 port dsp-api to Scala3

Base automatically changed from chore/scala3-compiler to main May 6, 2024 14:40
@seakayone seakayone force-pushed the chore/scala3-formatting branch from b475973 to 29b93d7 Compare May 6, 2024 15:07
@seakayone seakayone marked this pull request as ready for review May 6, 2024 15:07
@seakayone seakayone enabled auto-merge (squash) May 6, 2024 15:07
@seakayone seakayone merged commit 1dcf47b into main May 6, 2024
10 checks passed
@seakayone seakayone deleted the chore/scala3-formatting branch May 6, 2024 15:33
@daschbot daschbot mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

@siers siers Awaiting requested review from siers siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seakayone @BalduinLandolt