Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: KnoraSipiIntegrationV2ITSpec simplifications (DEV-3504) #3235

Merged
merged 12 commits into from
May 6, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented May 6, 2024

Pull Request Checklist

Task Description/Number

Refactoring changes are split per commits whose descriptions are (time ascending order):

  • reuse header adding code, reuse jsonLdHttpEntity
  • add WithAsIs(asOpt) and create assertingUnique
  • actually use jsonLdHttpEntity everywhere
  • def requestJsonLdWithAuth(request) = request with "~> addAuthorization"
  • reuse URLencode + getResponseJsonLD inlining
  • flatten some UploadFileRequest.make().toJsonLd calls
  • import OntologyConstants._ and the resulting changes
  • moving around a few things (diff: +10, -41)

Issues in tests discovered while working on DEV-3504.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

@siers siers self-assigned this May 6, 2024
Copy link

linear bot commented May 6, 2024

@siers
Copy link
Contributor Author

siers commented May 6, 2024

I'll let the CI for int. tests run, then I'll push the formatting.

@siers
Copy link
Contributor Author

siers commented May 6, 2024

Int. tests were green, pushed formatting.

@siers siers enabled auto-merge (squash) May 6, 2024 13:35
@siers siers merged commit 1d33541 into main May 6, 2024
9 of 10 checks passed
@siers siers deleted the refactor/knora-sipi-test branch May 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants