Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify shift code #3230

Merged
merged 3 commits into from
May 7, 2024
Merged

refactor: Simplify shift code #3230

merged 3 commits into from
May 7, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 2, 2024 •
edited
Loading

  • Replace throw BadRequest with fail
  • Replace throw BadRequest with fail
  • simplify if else by using match
  • remove duplicate scaladocs
  • Re-add missing scaladoc
  • Simplify shift code

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the base branch from main to fix/return-400-instead-of-500-for-list-node-creation May 2, 2024 13:41
Base automatically changed from fix/return-400-instead-of-500-for-list-node-creation to main May 2, 2024 13:51
@seakayone seakayone force-pushed the refactor/simplify-shift-code branch from c60dd37 to f7b8b19 Compare May 7, 2024 08:16
@seakayone seakayone marked this pull request as ready for review May 7, 2024 08:16
siers
siers approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I hope tests have your back!

@seakayone seakayone changed the title refactor/simplify shift code refactor: Simplify shift code May 7, 2024
@seakayone seakayone enabled auto-merge (squash) May 7, 2024 09:02
@seakayone seakayone merged commit a9f0840 into main May 7, 2024
11 of 12 checks passed
@seakayone seakayone deleted the refactor/simplify-shift-code branch May 7, 2024 09:02
@daschbot daschbot mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seakayone @siers @mpro7 @BalduinLandolt