Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace spray json with zio json for list endpoints #3226

Merged
merged 25 commits into from
May 2, 2024
Merged

refactor: Replace spray json with zio json for list endpoints #3226

merged 25 commits into from
May 2, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 1, 2024 •
edited
Loading

  • Remove spray dependency from /admin/list endpoints**
  • Remove unused NodePathElementADM
  • Move spray json formats for list models to integration source set

Contains changes from #3221 (merge first)

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the base branch from main to refactor/remove-ProjectIdentifier May 1, 2024 10:48
@seakayone seakayone force-pushed the refactor/remove-spray-from-list-endpoints branch from 6e3fe2f to 67d437e Compare May 1, 2024 10:52
@seakayone seakayone marked this pull request as ready for review May 1, 2024 12:48
Base automatically changed from refactor/remove-ProjectIdentifier to main May 2, 2024 07:15
mpro7
mpro7 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. There are still some code duplications and improvements which can be done on moved code, but this is I guess for later. Thanks!

...knora/webapi/messages/admin/responder/listsmessages/IntegrationTestListADMJsonProtocol.scala Outdated Show resolved Hide resolved
...knora/webapi/messages/admin/responder/listsmessages/IntegrationTestListADMJsonProtocol.scala Outdated Show resolved Hide resolved
seakayone and others added 2 commits May 2, 2024 10:21
@seakayone @mpro7
Update integration/src/test/scala/org/knora/webapi/messages/admin/res…
ed437bd 
…ponder/listsmessages/IntegrationTestListADMJsonProtocol.scala

Co-authored-by: Marcin Procyk <[email protected]>
@seakayone @mpro7
Update integration/src/test/scala/org/knora/webapi/messages/admin/res…
3b64db0 
…ponder/listsmessages/IntegrationTestListADMJsonProtocol.scala

Co-authored-by: Marcin Procyk <[email protected]>
siers
siers approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to move to zio json?

@seakayone
Copy link
Contributor Author

seakayone commented May 2, 2024 •
edited
Loading

Why is it necessary to move to zio json?

Two reasons:

  1. spray-json is not updated anymore since three years
  2. When migrating to Scala3 the integration with tapir is not working anymore

@seakayone seakayone enabled auto-merge (squash) May 2, 2024 09:12
@seakayone seakayone merged commit 1ba3473 into main May 2, 2024
11 checks passed
@seakayone seakayone deleted the refactor/remove-spray-from-list-endpoints branch May 2, 2024 09:30
@daschbot daschbot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @mpro7