Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unused trait IOValueV2 #3212

Merged
merged 2 commits into from
Apr 24, 2024
Merged

refactor: Remove unused trait IOValueV2 #3212

merged 2 commits into from
Apr 24, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Apr 24, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@siers siers self-assigned this Apr 24, 2024
@siers siers enabled auto-merge (squash) April 24, 2024 15:10
@siers siers merged commit 6ddb6c7 into main Apr 24, 2024
11 checks passed
@siers siers deleted the refactor/useless-trait branch April 24, 2024 15:28
@daschbot daschbot mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@seakayone seakayone seakayone approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

Assignees

@siers siers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siers @seakayone @BalduinLandolt