Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unused non-unit return type compiler warnings (Scala3 preparation) #3211

Merged
merged 3 commits into from
Apr 25, 2024
Merged

refactor: Remove unused non-unit return type compiler warnings (Scala3 preparation) #3211

merged 3 commits into from
Apr 25, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 24, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title refactor: Remove unused non-unit return type compiler warnings (Scala3 perparation) refactor: Remove unused non-unit return type compiler warnings (Scala3 preparation) Apr 24, 2024
@seakayone seakayone marked this pull request as ready for review April 24, 2024 13:34
@seakayone seakayone enabled auto-merge (squash) April 25, 2024 14:00
@seakayone seakayone merged commit d75c9b5 into main Apr 25, 2024
11 checks passed
@seakayone seakayone deleted the chore/scala3-prep-unused-non-unit-return branch April 25, 2024 14:19
@daschbot daschbot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seakayone @siers @mpro7 @BalduinLandolt