Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support table headers in formatted text (DEV-3473) #3210

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Apr 23, 2024
Copy link

linear bot commented Apr 23, 2024

@BalduinLandolt BalduinLandolt marked this pull request as ready for review April 24, 2024 07:31
@seakayone
Copy link
Contributor

seakayone commented Apr 24, 2024

question: As far as I understand the colspan tag is the problem in the bug report, isn't it?

or merged cell in table leads to error

@BalduinLandolt
Copy link
Contributor Author

question: As far as I understand the colspan tag is the problem in the bug report, isn't it?

or merged cell in table leads to error

the merge cell feature has been deactivated in the frontend, so there was no immediate need to add that for now. We could re-enable it and add it too, but this was more immediately an issue, and I think it would make sense to ensure that this works first. But I'm open for discussion, if you think that should be done in one go

@BalduinLandolt BalduinLandolt merged commit c17e7f8 into main Apr 24, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3473-ckeditor-using-header-row-or-merged-cell-in-table-leads-to branch April 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants