Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move GroupStatus update from responder to services (DEV-3292) #3195

Merged
merged 8 commits into from
Apr 19, 2024
Merged

refactor: Move GroupStatus update from responder to services (DEV-3292) #3195

merged 8 commits into from
Apr 19, 2024

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Apr 17, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Apart of moving update method also have been added:

  • tests for GroupService,
  • KnoraGroupRepoLiveSpec missing members implementation,
  • methods that allow to cope with KnoraGroup instead of Group in KnoraUserService,
  • findByGroupMembership method in KnoraUserRepoLive

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@linear Linear
Copy link

linear bot commented Apr 17, 2024

DEV-3292 Remove the `GroupsResponder`

@mpro7 mpro7 changed the title Dev 3292 6 refactor: Move GroupStatus update from responder to services (DEV-3292) Apr 18, 2024
@mpro7 mpro7 marked this pull request as ready for review April 18, 2024 07:33
@mpro7 mpro7 self-assigned this Apr 18, 2024
@seakayone seakayone self-requested a review April 18, 2024 10:43
@mpro7 mpro7 enabled auto-merge (squash) April 19, 2024 07:39
@mpro7 mpro7 merged commit 3e08df7 into main Apr 19, 2024
10 of 11 checks passed
@mpro7 mpro7 deleted the dev-3292-6 branch April 19, 2024 07:42
@daschbot daschbot mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siers siers siers approved these changes

@seakayone seakayone seakayone approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees

@mpro7 mpro7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpro7 @seakayone @siers