refactor: Move Group update from responder to services (DEV-3292) #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siers
reviewed
Apr 16, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/KnoraGroupService.scala
Show resolved
Hide resolved
seakayone
approved these changes
Apr 17, 2024
| .when(List(request.name, request.descriptions, request.status, request.selfjoin).flatten.isEmpty) | ||
| groupToUpdate <- groupService | ||
| .findById(iri) | ||
| .someOrFail(NotFoundException(s"Group <${iri.value}> not found.")) | ||
| _ <- auth.ensureSystemAdminOrProjectAdminOfGroup(user, iri) |
There was a problem hiding this comment.
suggestion: I think the authorisation check should be done first.
There was a problem hiding this comment.
When it is like that, in the test return 'NotFound' if a not-existing group IRI is submitted during update I'm getting ForbiddenException instead of expected NotFoundException. Not sure why...
I will change it in follow-up PR if this is necessary.
There was a problem hiding this comment.
You could provide a user in the test which is actually allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?