Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove @accessible (Scala3 preparation) #3183

Merged
merged 11 commits into from
Apr 11, 2024
Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 11, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone enabled auto-merge (squash) April 11, 2024 06:53
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 13.68%. Comparing base (a622e4f) to head (98b9dd8).
Report is 8 commits behind head on main.

❗ Current head 98b9dd8 differs from pull request most recent head 11bbcee. Consider uploading reports for the commit 11bbcee to get more accurate results

Files Patch % Lines
...la/org/knora/webapi/routing/v2/ValuesRouteV2.scala 0.00% 6 Missing ⚠️
...rg/knora/webapi/routing/v2/OntologiesRouteV2.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3183      +/-   ##
==========================================
+ Coverage   13.22%   13.68%   +0.46%     
==========================================
  Files         270      272       +2     
  Lines       22244    22206      -38     
==========================================
+ Hits         2941     3040      +99     
+ Misses      19303    19166     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@seakayone seakayone merged commit 993538d into main Apr 11, 2024
11 of 12 checks passed
@seakayone seakayone deleted the chore/rm-accessible branch April 11, 2024 08:26
@seakayone
Copy link
Contributor Author

🦾

Thanks to the power of vim macros that was not so bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants