Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add scopes to tokens issued by JwtService (DEV-3451) #3178

Merged
merged 13 commits into from
Apr 10, 2024
Merged

feat: Add scopes to tokens issued by JwtService (DEV-3451) #3178

merged 13 commits into from
Apr 10, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 9, 2024 •
edited
Loading

  • Move code to KnoraUserToUserConverter
  • Migrate JwtServiceLiveSpec to zio-test
  • Calculate scope values based on the user's permissions and add them to the access token as scope in jwt

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone force-pushed the feat/add-scopes-to-JwtService branch from 6dfa4c6 to c79e9cc Compare April 9, 2024 12:29
@seakayone seakayone changed the title feat/add scopes to JwtService feat: Add scopes to tokens issued by JwtService Apr 10, 2024
@seakayone seakayone force-pushed the feat/add-scopes-to-JwtService branch from b2de31e to 48fae72 Compare April 10, 2024 06:35
@seakayone seakayone force-pushed the feat/add-scopes-to-JwtService branch from 001d27a to 3c62dc9 Compare April 10, 2024 10:34
@seakayone seakayone marked this pull request as ready for review April 10, 2024 11:02
@seakayone seakayone changed the title feat: Add scopes to tokens issued by JwtService feat: Add scopes to tokens issued by JwtService (DEV-3451) Apr 10, 2024
@linear Linear
Copy link

linear bot commented Apr 10, 2024

DEV-3451 Include permission in access token scope

@seakayone seakayone merged commit 73fc75f into main Apr 10, 2024
11 checks passed
@seakayone seakayone deleted the feat/add-scopes-to-JwtService branch April 10, 2024 13:13
@daschbot daschbot mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siers siers siers left review comments

@mpro7 mpro7 mpro7 approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @mpro7