Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract ObjectAccess and Administrative permissions into Permission model in admin slice #3152

Merged
merged 18 commits into from
Apr 2, 2024

Merge branch 'main' into refactor/permissions

6454b6d
Select commit
Loading
Failed to load commit list.
Merged

refactor: Extract ObjectAccess and Administrative permissions into Permission model in admin slice #3152

Merge branch 'main' into refactor/permissions
6454b6d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2024 in 1s

88.74% (-0.05%) compared to 62260e4, passed because coverage increased by +0.01% when compared to adjusted base (88.72%)

View this Pull Request on Codecov

88.74% (-0.05%) compared to 62260e4, passed because coverage increased by +0.01% when compared to adjusted base (88.72%)

Details

Codecov Report

Attention: Patch coverage is 95.49550% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.74%. Comparing base (62260e4) to head (6454b6d).
Report is 6 commits behind head on main.

Files Patch % Lines
...knora/webapi/messages/util/PermissionUtilADM.scala 91.30% 2 Missing ⚠️
...rg/knora/webapi/responders/v2/ResourceUtilV2.scala 66.66% 2 Missing ⚠️
...api/responders/admin/PermissionsResponderADM.scala 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
- Coverage   88.79%   88.74%   -0.05%     
==========================================
  Files         265      266       +1     
  Lines       22260    22274      +14     
==========================================
+ Hits        19765    19767       +2     
- Misses       2495     2507      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.