Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump sipi to 3.10.1 #3150

Merged
merged 1 commit into from
Mar 27, 2024
Merged

chore: Bump sipi to 3.10.1 #3150

merged 1 commit into from
Mar 27, 2024

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Mar 26, 2024

Pull Request Checklist

Task Description/Number

Related to DEV-3298

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Mar 26, 2024

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (a9a7993) to head (f17cf1a).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3150       +/-   ##
===========================================
+ Coverage   13.33%   88.79%   +75.45%     
===========================================
  Files         265      265               
  Lines       22260    22260               
===========================================
+ Hits         2969    19765    +16796     
+ Misses      19291     2495    -16796     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subotic
Copy link
Collaborator Author

subotic commented Mar 26, 2024

@mpro7 @seakayone This version of Sipi is fixing the watermark caching issue. Any possibility to make a new release of dsp-api, deploy it to staging, and finally to prod if everything works?

@subotic subotic self-assigned this Mar 26, 2024
@subotic subotic enabled auto-merge (squash) March 26, 2024 22:57
@subotic subotic merged commit 97b8b82 into main Mar 27, 2024
13 checks passed
@subotic subotic deleted the wip/bump-sipi-to-3.10.1 branch March 27, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants