Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure all project's restricted view settings are correctly persisted #3125

Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Mar 18, 2024

  • fix: Add upgrade plugin which ensures all projects have valid RestrictedView settings persisted

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone force-pushed the fix/ensure-restricted-view-settings-are-correctly-persisted branch from 76449da to 477d50e Compare March 18, 2024 10:07
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 13.13%. Comparing base (eac5751) to head (9877d23).
Report is 137 commits behind head on main.

Files Patch % Lines
...bapi/src/main/scala/org/knora/webapi/package.scala 0.00% 1 Missing ⚠️
...ore/triplestore/upgrade/RepositoryUpdatePlan.scala 0.00% 1 Missing ⚠️
...plestore/upgrade/plugins/UpgradePluginPR3112.scala 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
+ Coverage   11.74%   13.13%   +1.38%     
==========================================
  Files         246      266      +20     
  Lines       22907    22413     -494     
==========================================
+ Hits         2690     2943     +253     
+ Misses      20217    19470     -747     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as draft March 18, 2024 10:15
@seakayone seakayone marked this pull request as ready for review March 18, 2024 10:54
@seakayone seakayone self-assigned this Mar 18, 2024
@seakayone seakayone enabled auto-merge (squash) March 18, 2024 15:23
@seakayone seakayone merged commit 51cde02 into main Mar 18, 2024
13 checks passed
@seakayone seakayone deleted the fix/ensure-restricted-view-settings-are-correctly-persisted branch March 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants