test: Improve test for serving ontologies in different formats

[BalduinLandolt]

Pull Request Checklist

Task Description

This PR attempts to make the approval tests more ergonomic and feel more like "real" approval tests.
It also removes redundant test cases.

• The knora-api can be retrieved through two separate routes; instead of checking both against the same files, the test now ensures that both routes return the same content.
• The number of test cases was radically reduced
  • testing exactly the following things (both in simple and complex schema; and in the formats turtle, JSON-LD and RDF-XML):
    • the built-in ontologies knora-api, salsah-gui and standoff
    • a class definition from a built-in ontology
    • a property definition from a built-in ontology
    • metadata of a project ontology
    • a project ontology
    • a project ontology returning labels in all languages
    • a class definition of a project ontology
    • a property definition of a project ontology
  • the following test cases were removed because they were redundant according to the above systematic
    • allOntologyMetadata
    • incunabulaOntologyMetadata
    • beolOntologyMetadata
    • incunabulaOntologySimple
    • incunabulaOntologyWithValueObjects
    • knoraApiSimpleHasColor
    • knoraApiWithValueObjectsHasColor
    • incunabulaSimplePubDate
    • incunabulaWithValueObjectsPubDate
    • incunabulaPageAndBookWithValueObjects
    • boxOntologyWithValueObjects
    • minimalOntologyWithValueObjects
    • imagesBild
    • incunabulaBook
    • incunabulaPage
    • anythingHasDate
    • imagesTitel
    • incunabulaPartOf
  • the following test cases have been added to fulfil the above systematic
    • anythingOntologySimple
    • anythingHasListItemSimple
    • anythingHasListItem
    • anythingThingSimple
    • anythingThing
  • the following test cases are no longer available in the client test data
    • all-ontology-metadata-response
    • get-ontologies-project-incunabula-response
    • get-ontologies-project-beol-response
    • incunabula-ontology
    • minimal-ontology
    • get-class-image-bild-response
    • get-class-incunabula-book-response
    • get-property-DateValue-response
    • get-property-textValue-response
    • get-property-linkvalue-response

PR Type

• build/chore: maintenance tasks (no production code change)
• docs: documentation changes (no production code change)
• feat: represents new features
• fix: represents bug fixes
• perf: performance improvements
• refactor: represents production code refactoring
• test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

• Tests for the changes have been added
• Docs have been added / updated

Does this PR introduce a breaking change?

• Yes

Does this PR change client-test-data?

• Yes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.15%. Comparing base (eac5751) to head (fdc73a3).
Report is 143 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3115      +/-   ##
==========================================
+ Coverage   11.74%   13.15%   +1.40%     
==========================================
  Files         246      264      +18     
  Lines       22907    22395     -512     
==========================================
+ Hits         2690     2945     +255     
+ Misses      20217    19450     -767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[siers]

Judging by the description sounds good, however one question – could it be that some routes now have less integration test coverage?

[BalduinLandolt]

Judging by the description sounds good, however one question – could it be that some routes now have less integration test coverage?

this test (mostly) only tests one route, so it is fairly confined where we might have lost coverage. The only thing I can think of that might have lost test coverage now, is if we have any ontology features that were used in some of the no-longer-requested project ontologies, but are not used in the anything ontology (which is still tested here). But this would be limited to things like different value types or stuff like that, so if we lose any coverage here at all, it should only be stuff that is covered by other tests. But I can't say 100% for sure.

[mpro7]

I guess corresponding tests tests need to be removed on the dsp-js side... :)