-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(knora-admin): Remove unused Institution class and its properties (DEV-3365) #3109
refactor(knora-admin): Remove unused Institution class and its properties (DEV-3365) #3109
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
===========================================
+ Coverage 11.74% 88.77% +77.03%
===========================================
Files 246 262 +16
Lines 22907 22396 -511
===========================================
+ Hits 2690 19883 +17193
+ Misses 20217 2513 -17704 ☔ View full report in Codecov by Sentry. |
77de981
to
66105eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Would you mind adding this to the migrations RFC? I think that's already a bit more ergonomical than it used to be - and it should be fast since it works only on one graph.
.../src/main/scala/org/knora/webapi/store/triplestore/upgrade/plugins/UpgradePluginPR3110.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?