-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Prevent illegal updates with KnoraUserService
#3098
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
+ Coverage 11.74% 12.92% +1.18%
==========================================
Files 246 260 +14
Lines 22907 22339 -568
==========================================
+ Hits 2690 2887 +197
+ Misses 20217 19452 -765 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion:
lang: Option[LanguageCode] = None, | ||
): Task[KnoraUser] = { | ||
val theUpdate = | ||
UserChangeRequest(username = username, email = email, givenName = givenName, familyName = familyName, lang = lang) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UserChangeRequest(username = username, email = email, givenName = givenName, familyName = familyName, lang = lang) | |
UserChangeRequest(username, email, givenName, familyName, lang) |
UserChangeRequest
privateSystemAdmin
andUserStatus
with dedicated methodsPull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?