Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Feat/more spray removal #3096

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.60%. Comparing base (32685a0) to head (e1ad383).

❗ Current head e1ad383 differs from pull request most recent head a072050. Consider uploading reports for the commit a072050 to get more accurate results

Files Patch % Lines
...ice/admin/api/service/ProjectsADMRestService.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           feature/dev-3375-introduce-zio-json-in-projects-routes    #3096      +/-   ##
==========================================================================================
- Coverage                                                   88.62%   88.60%   -0.03%     
==========================================================================================
  Files                                                         261      260       -1     
  Lines                                                       22392    22387       -5     
==========================================================================================
- Hits                                                        19846    19837       -9     
- Misses                                                       2546     2550       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt merged commit a072050 into feature/dev-3375-introduce-zio-json-in-projects-routes Mar 5, 2024
4 of 8 checks passed
@BalduinLandolt BalduinLandolt deleted the feat/more-spray-removal branch March 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant