Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add save to KnoraProjectRepo and use for setting the RestrictedView #3082

Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Mar 4, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the base branch from main to feat/either-restricted-view-or-watermark March 4, 2024 16:26
Base automatically changed from feat/either-restricted-view-or-watermark to main March 4, 2024 16:30
@seakayone seakayone force-pushed the refactor/introduce-save-on-KnoraRepo-use-for-restricted-view branch from 678d9cd to d161198 Compare March 4, 2024 16:31
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.61%. Comparing base (eac5751) to head (d161198).
Report is 102 commits behind head on main.

Files Patch % Lines
...lice/admin/repo/service/KnoraProjectRepoLive.scala 97.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3082       +/-   ##
===========================================
+ Coverage   11.74%   88.61%   +76.87%     
===========================================
  Files         246      261       +15     
  Lines       22907    22396      -511     
===========================================
+ Hits         2690    19846    +17156     
+ Misses      20217     2550    -17667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review March 4, 2024 16:53
@seakayone seakayone self-assigned this Mar 5, 2024
@siers siers changed the title refactor: Add save to KnoraRepo and use for setting the RestrictedView refactor: Add save to KnoraProjectRepo and use for setting the RestrictedView Mar 5, 2024
@seakayone seakayone merged commit fcd483f into main Mar 5, 2024
15 checks passed
@seakayone seakayone deleted the refactor/introduce-save-on-KnoraRepo-use-for-restricted-view branch March 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants