refactor: KnoraUserGroup and KnoraUserGroupRepo (DEV-3288) #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
===========================================
+ Coverage 11.74% 88.67% +76.92%
===========================================
Files 246 263 +17
Lines 22907 22430 -477
===========================================
+ Hits 2690 19889 +17199
+ Misses 20217 2541 -17676 ☔ View full report in Codecov by Sentry. |
siers
force-pushed
the
chore/DEV-3288-knora-user-group-repository
branch
3 times, most recently
from
47b5a42 to
0b8e9d4
Compare
siers
commented
Feb 29, 2024
webapi/src/test/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroupSpec.scala
Show resolved
Hide resolved
siers
changed the title
siers
force-pushed
the
chore/DEV-3288-knora-user-group-repository
branch
2 times, most recently
from
cb61b25 to
7fc89fd
Compare
siers
force-pushed
the
chore/DEV-3288-knora-user-group-repository
branch
from
7fc89fd to
ffce932
Compare
siers
requested review from
BalduinLandolt,
mpro7 and
seakayone
and removed request for
BalduinLandolt,
mpro7 and
seakayone
BalduinLandolt
approved these changes
Feb 29, 2024
webapi/src/main/scala/org/knora/webapi/slice/common/repo/rdf/RdfModel.scala
Show resolved
Hide resolved
...pi/src/test/scala/org/knora/webapi/slice/admin/repo/service/KnoraUserGroupRepoLiveSpec.scala
Outdated
Show resolved
Hide resolved
mpro7
requested changes
Feb 29, 2024
.../main/scala/org/knora/webapi/messages/admin/responder/groupsmessages/GroupsPayloadsADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroup.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroup.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroup.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroup.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/KnoraUserGroup.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/repo/service/KnoraUserGroupRepoLive.scala
Outdated
Show resolved
Hide resolved
siers
force-pushed
the
chore/DEV-3288-knora-user-group-repository
branch
from
5223382 to
ea34116
Compare
seakayone
requested changes
Mar 1, 2024
| def save(userGroup: KnoraUserGroup): Task[KnoraUserGroup] = | ||
| for { | ||
| query <- findById(userGroup.id).map { | ||
| case Some(_) => throw new TriplestoreUnsupportedFeatureException("Updating users is not supported.") |
There was a problem hiding this comment.
issue: The save method suggests it could persisted a new or existing group but fails on update
I would suggest you implement this similar to the save query in the user repo. This query is able to create a new user or update an existing. There is also no need for findById pre-query as the save query does is in one go.
There was a problem hiding this comment.
Take a look, what do you think?
mpro7
approved these changes
Mar 4, 2024
seakayone
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is somewhere between a chore and a refactor.
1.1. GroupDefinitions head
1.2. KnoraUserGroupRepoLive created with find/save method
1.3. getObjectIrisConvert used from KnoraUserRepoLive and reused
3.1. Methods in AuthorizationRestService sorted according to call order
3.2. Missing belongsToGroup handled (its absence is valid according to the ontology)
Pull Request Checklist
Task Description/Number
Issue Number: DEV-3288
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?