Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate more users endpoint to tapir #3045

Closed
wants to merge 6 commits into from

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Feb 14, 2024

  • Add ensureSystemAdminOrProjectAdmin(User, ProjectIri) to AuthorizationRestService
  • Migrate PUT /admin/users/iri/<userIri>/SystemAdmin to Tapir
  • Migrate POST /admin/users/iri/<userIri>/project-memberships/<projectIri> to Tapir
  • Migrate DELETE /admin/users/iri/<userIri>/project-memberships/<projectIri> to Tapir
  • Migrate POST /admin/users/iri/<userIri>/project-admin-memberships/<projectIri> to Tapir
  • Migrate DELETE /admin/users/iri/<userIri>/project-admin-memberships/<projectIri> to Tapir

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title refactor/migrate more users endpoint to tapir refactor: Migrate more users endpoint to tapir Feb 14, 2024
@seakayone seakayone force-pushed the refactor/migrate-more-users-endpoint-to-tapir branch from 9f80151 to 2b46dd3 Compare February 14, 2024 15:56
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (e51e3e3) 88.74%.
Report is 67 commits behind head on main.

Files Patch % Lines
...src/main/scala/dsp/valueobjects/LanguageCode.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3045       +/-   ##
===========================================
+ Coverage   11.74%   88.74%   +76.99%     
===========================================
  Files         246      262       +16     
  Lines       22907    22728      -179     
===========================================
+ Hits         2690    20169    +17479     
+ Misses      20217     2559    -17658     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone closed this Feb 15, 2024
@seakayone seakayone deleted the refactor/migrate-more-users-endpoint-to-tapir branch February 15, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant