-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add option to make warnings non-fatal locally. #3044
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
+ Coverage 11.74% 11.99% +0.24%
==========================================
Files 246 262 +16
Lines 22907 22739 -168
==========================================
+ Hits 2690 2727 +37
+ Misses 20217 20012 -205 ☔ View full report in Codecov by Sentry. |
Works great, thanks. |
There is only a small problem when switching branches:
In order to be able to switch the branch I had to do: Is there an easier way, would |
Yes, that does happen, but it will be not a problem, once your other
branches have this commit.
…On Wed, 14 Feb 2024, 18:12 Christian Kleinbölting, ***@***.***> wrote:
Works great, thanks.
There is only a small problem when switching branches:
❯ git update-index --skip-worktree project/LocalSettings.scala
❯ git status
On branch chore/sbt-local-settings
Your branch is up to date with 'origin/chore/sbt-local-settings'.
nothing to commit, working tree clean
❯ git checkout main
error: Your local changes to the following files would be overwritten by checkout:
project/LocalSettings.scala
Please commit your changes or stash them before you switch branches.
Aborting
In order to be able to switch the branch I had to do:
git update-index --no-skip-worktree project/LocalSettings.scala
Is there an easier way, would assume-unchanged work better?
—
Reply to this email directly, view it on GitHub
<#3044 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZNC5ASFMXEIY6YP3WRBTYTTV6NAVCNFSM6AAAAABDIQGWQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGI2TQOJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This PR makes
-Xfatal-warnings
ergonomically disableable locally.Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?