Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add -Xfatal-warnings #3042

Merged
merged 4 commits into from
Feb 13, 2024
Merged

chore: Add -Xfatal-warnings #3042

merged 4 commits into from
Feb 13, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 13, 2024

There were quite a few warnings left, all of which I fixed and enabled -Xfatal-warnings. What do you think about this change?

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (bcda49d) 11.91%.
Report is 65 commits behind head on main.

Files Patch % Lines
...src/main/scala/dsp/valueobjects/LanguageCode.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
+ Coverage   11.74%   11.91%   +0.17%     
==========================================
  Files         246      262      +16     
  Lines       22907    22803     -104     
==========================================
+ Hits         2690     2718      +28     
+ Misses      20217    20085     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers force-pushed the chore/fatal-warnings branch from ce2d9cf to ff3a3a1 Compare February 13, 2024 12:19
@siers siers self-assigned this Feb 13, 2024
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@siers siers force-pushed the chore/fatal-warnings branch from ff3a3a1 to 999a35f Compare February 13, 2024 14:52
Copy link
Contributor

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

Fine for me to let the compile fail with new warnings.

@siers siers enabled auto-merge (squash) February 13, 2024 17:36
@siers siers merged commit 8e51a94 into main Feb 13, 2024
13 checks passed
@siers siers deleted the chore/fatal-warnings branch February 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants