-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add -Xfatal-warnings #3042
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
+ Coverage 11.74% 11.91% +0.17%
==========================================
Files 246 262 +16
Lines 22907 22803 -104
==========================================
+ Hits 2690 2718 +28
+ Misses 20217 20085 -132 ☔ View full report in Codecov by Sentry. |
ce2d9cf
to
ff3a3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
integration/src/test/scala/org/knora/webapi/responders/v2/ResourcesResponderV2Spec.scala
Outdated
Show resolved
Hide resolved
integration/src/test/scala/org/knora/webapi/responders/v2/ValuesResponderV2Spec.scala
Outdated
Show resolved
Hide resolved
integration/src/test/scala/org/knora/webapi/responders/v2/ValuesResponderV2Spec.scala
Outdated
Show resolved
Hide resolved
ff3a3a1
to
999a35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks.
Fine for me to let the compile fail with new warnings.
There were quite a few warnings left, all of which I fixed and enabled
-Xfatal-warnings
. What do you think about this change?Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?