Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove token property from user which is always None #3041

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Feb 9, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title Remove token property from user which is always None refactor: Remove token property from user which is always None Feb 9, 2024
@seakayone seakayone self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (2fb770f) 88.62%.
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3041       +/-   ##
===========================================
+ Coverage   11.74%   88.62%   +76.88%     
===========================================
  Files         246      259       +13     
  Lines       22907    22855       -52     
===========================================
+ Hits         2690    20256    +17566     
+ Misses      20217     2599    -17618     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@seakayone seakayone merged commit 1b7f88b into main Feb 12, 2024
14 checks passed
@seakayone seakayone deleted the refactor/remove-token-property-from-user branch February 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants