Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update scala-graph to 2.0.1 (DEV-3072) #3031

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 7, 2024

The .outers in the code refer to the nodes that are stripped of graph's internal bookkeeping information, so that should be equivalent to the old .value.

The other changes should also be rather mundane, like change of constructor names (Graph(..) -> Graph.from(List(..)) and DiHyperEdge(a, b) -> DiHyperEdge(a)(b)).

I wrote 2.0.1 should be compatible in the comment, however I didn't explicitly check it, but comments seemed to suggest it was.

Minor detail: the current CI build is run with commits based on the previous PR, which doesn't do any harm, maybe I'll remove them in the second run, if it's not merged yet.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Feb 7, 2024

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (fb3664f) 88.62%.
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3031       +/-   ##
===========================================
+ Coverage   11.74%   88.62%   +76.88%     
===========================================
  Files         246      259       +13     
  Lines       22907    22860       -47     
===========================================
+ Hits         2690    20260    +17570     
+ Misses      20217     2600    -17617     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers force-pushed the chore/scala-graph-update branch from d14bb12 to be4d30b Compare February 7, 2024 17:21
@siers siers requested review from seakayone, mpro7 and BalduinLandolt and removed request for mpro7 February 8, 2024 08:17
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just remember to add yourself as assignee. It makes easier to filter PRs out.

@siers siers self-assigned this Feb 8, 2024
@siers siers merged commit 9b04b8f into main Feb 8, 2024
12 of 13 checks passed
@siers siers deleted the chore/scala-graph-update branch February 8, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants