-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change RDF handling for querying Projects from DB (DEV-3175) #2989
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
- Coverage 11.74% 11.60% -0.14%
==========================================
Files 246 260 +14
Lines 22907 22929 +22
==========================================
- Hits 2690 2661 -29
- Misses 20217 20268 +51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I was introduced to this by Balduin.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have just had some minor note for improving this, please address them before merging.
webapi/src/main/scala/org/knora/webapi/slice/common/repo/rdf/RdfModel.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/common/repo/rdf/RdfModel.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/slice/common/repo/rdf/RdfModelSpec.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: Christian Kleinbölting <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have one question, not sure if important, but please address it before merge:
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?