Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add just targets for simple stack handling #2985

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Jan 9, 2024

Pull Request Checklist

Task Description/Number

@irmastnt this automates the commands that worked yesterday which are a lot faster than make stack-up which first has to build images for SIPI and the API.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (92019f9) 11.60%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
- Coverage   11.74%   11.60%   -0.14%     
==========================================
  Files         246      255       +9     
  Lines       22907    22989      +82     
==========================================
- Hits         2690     2669      -21     
- Misses      20217    20320     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justfile Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@seakayone
Copy link
Contributor

@BalduinLandolt as discussed, I have added the recipes and fine tuned it a bit.

Please have a look.

@seakayone seakayone self-requested a review January 10, 2024 09:03
@BalduinLandolt
Copy link
Contributor Author

@BalduinLandolt as discussed, I have added the recipes and fine tuned it a bit.

Please have a look.

I like it much better now, thanks!
Do we want to have an alias for most commands? then stack-restart might be a candidate

Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add aliases for starting, restarting and destroying stack, but feel free to ignore in this PR.

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) January 10, 2024 17:24
@BalduinLandolt BalduinLandolt merged commit f5f135e into main Jan 10, 2024
13 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/add-just-target-for-simpler-stack-starting branch January 10, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants