-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add generating OpenApi yamls for the admin api (DEV-1812) #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
requested review from
mpro7 and
BalduinLandolt
and removed request for
mpro7
January 9, 2024 12:34
BalduinLandolt
approved these changes
Jan 9, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/api/ProjectsEndpoints.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
===========================================
+ Coverage 11.74% 88.45% +76.71%
===========================================
Files 246 253 +7
Lines 22907 23015 +108
===========================================
+ Hits 2690 20359 +17669
+ Misses 20217 2656 -17561 ☔ View full report in Codecov by Sentry. |
mpro7
approved these changes
Jan 9, 2024
webapi/src/main/scala/org/knora/webapi/slice/common/api/DocsGenerator.scala
Show resolved
Hide resolved
seakayone
changed the title
feat: Add generating OpenApi yamls for the admin api
feat: Add generating OpenApi yamls for the admin api (DEV-1812)
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
For now the open api documentation is only generated on demand by calling
just dog
.This should enable @BalduinLandolt and @mpro7 to integrate their newly migrated endpoints, so that in future we are able to:
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?