Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Streamline User identifiers (DEV-3155) #2979

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jan 8, 2024
Copy link

linear bot commented Jan 8, 2024

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (37a426d) 11.76%.
Report is 6 commits behind head on main.

❗ Current head 37a426d differs from pull request most recent head d87283f. Consider uploading reports for the commit d87283f to get more accurate results

Files Patch % Lines
...g/knora/webapi/slice/admin/domain/model/User.scala 0.00% 40 Missing ⚠️
...ra/webapi/responders/admin/UsersResponderADM.scala 0.00% 28 Missing ⚠️
...knora/webapi/store/iiif/impl/SipiServiceLive.scala 0.00% 16 Missing ⚠️
...webapi/responders/admin/ProjectsResponderADM.scala 0.00% 11 Missing ⚠️
.../knora/webapi/slice/admin/api/UsersEndpoints.scala 0.00% 6 Missing ⚠️
...s/v2/responder/valuemessages/ValueMessagesV2.scala 58.33% 5 Missing ⚠️
...webapi/slice/admin/api/UsersEndpointsHandler.scala 0.00% 3 Missing ⚠️
...a/webapi/responders/admin/GroupsResponderADM.scala 0.00% 2 Missing ⚠️
...scala/org/knora/webapi/routing/Authenticator.scala 0.00% 2 Missing ⚠️
.../slice/admin/api/service/UsersADMRestService.scala 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
+ Coverage   11.74%   11.76%   +0.02%     
==========================================
  Files         246      250       +4     
  Lines       22907    22934      +27     
==========================================
+ Hits         2690     2698       +8     
- Misses      20217    20236      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt deleted the feature/dev-3155-streamline-user-identifier-objects-2 branch January 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant