-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move and rename UserADM #2978
Merged
BalduinLandolt
merged 8 commits into
main
from
feature/dev-3155-streamline-user-identifier-objects
Jan 8, 2024
Merged
refactor: Move and rename UserADM #2978
BalduinLandolt
merged 8 commits into
main
from
feature/dev-3155-streamline-user-identifier-objects
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
===========================================
+ Coverage 11.74% 88.57% +76.82%
===========================================
Files 246 250 +4
Lines 22907 22934 +27
===========================================
+ Hits 2690 20313 +17623
+ Misses 20217 2621 -17596 ☔ View full report in Codecov by Sentry. |
BalduinLandolt
changed the title
refactor: Streamline User Identifiers (DEV-3155)
refactor: Move and rename UserADM
Jan 8, 2024
seakayone
approved these changes
Jan 8, 2024
mpro7
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
BalduinLandolt
deleted the
feature/dev-3155-streamline-user-identifier-objects
branch
January 8, 2024 13:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?