Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move and rename UserADM #2978

Merged

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Jan 8, 2024

Pull Request Checklist

Task Description/Number

Issue Number

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jan 8, 2024
Copy link

linear bot commented Jan 8, 2024

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (0a0c053) 88.57%.
Report is 5 commits behind head on main.

Files Patch % Lines
...ra/webapi/responders/admin/UsersResponderADM.scala 71.42% 8 Missing ⚠️
...g/knora/webapi/slice/admin/domain/model/User.scala 87.50% 5 Missing ⚠️
...scala/org/knora/webapi/routing/Authenticator.scala 50.00% 1 Missing ⚠️
.../slice/admin/api/service/UsersADMRestService.scala 50.00% 1 Missing ⚠️
...i/slice/admin/domain/service/DspIngestClient.scala 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2978       +/-   ##
===========================================
+ Coverage   11.74%   88.57%   +76.82%     
===========================================
  Files         246      250        +4     
  Lines       22907    22934       +27     
===========================================
+ Hits         2690    20313    +17623     
+ Misses      20217     2621    -17596     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review January 8, 2024 12:01
@BalduinLandolt BalduinLandolt changed the title refactor: Streamline User Identifiers (DEV-3155) refactor: Move and rename UserADM Jan 8, 2024
Copy link

linear bot commented Jan 8, 2024

Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BalduinLandolt BalduinLandolt merged commit 56c1feb into main Jan 8, 2024
19 of 20 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3155-streamline-user-identifier-objects branch January 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants