Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate admin/permissions endpoints to tapir (DEV-1590) #2975

Merged
merged 37 commits into from
Jan 9, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Dec 28, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Dec 28, 2023
@seakayone seakayone changed the title Add createAdministrativePermission endpoint refactor: Migrate admin/permissions endpoints to tapir Dec 28, 2023
@seakayone seakayone changed the title refactor: Migrate admin/permissions endpoints to tapir refactor: Migrate admin/permissions endpoints to tapir (DEV-1590) Dec 28, 2023
Copy link

linear bot commented Dec 28, 2023

Copy link

swarmia bot commented Dec 28, 2023

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (65ee8f2) 11.72%.
Report is 10 commits behind head on main.

Files Patch % Lines
webapi/src/main/scala/dsp/valueobjects/User.scala 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2975      +/-   ##
==========================================
- Coverage   11.74%   11.72%   -0.02%     
==========================================
  Files         246      250       +4     
  Lines       22907    22925      +18     
==========================================
- Hits         2690     2689       -1     
- Misses      20217    20236      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone force-pushed the refactor/migrate-admin-permissions-to-tapir branch from 28fe092 to de8fc16 Compare December 28, 2023 15:59
@seakayone seakayone marked this pull request as ready for review January 8, 2024 14:14
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most detailed review from my side, but overall looks good, much cleaner than before. (Spotted one typo)

Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 minor comments you can ignore for now.

@seakayone seakayone enabled auto-merge (squash) January 9, 2024 10:14
@seakayone seakayone merged commit cf2c6fb into main Jan 9, 2024
13 checks passed
@seakayone seakayone deleted the refactor/migrate-admin-permissions-to-tapir branch January 9, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants