-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate admin/permissions
endpoints to tapir (DEV-1590)
#2975
Conversation
admin/permissions
endpoints to tapir
admin/permissions
endpoints to tapiradmin/permissions
endpoints to tapir (DEV-1590)
✅ Linked to Story DEV-1590 · DSP-API: Expose admin/permissions routes with ZIO HTTP |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
- Coverage 11.74% 11.72% -0.02%
==========================================
Files 246 250 +4
Lines 22907 22925 +18
==========================================
- Hits 2690 2689 -1
- Misses 20217 20236 +19 ☔ View full report in Codecov by Sentry. |
28fe092
to
de8fc16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most detailed review from my side, but overall looks good, much cleaner than before. (Spotted one typo)
integration/src/test/scala/org/knora/webapi/util/ZioScalaTestUtil.scala
Outdated
Show resolved
Hide resolved
…til.scala Co-authored-by: Balduin Landolt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 2 minor comments you can ignore for now.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?