Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Sipi to 3.8.8 #2972

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore: Bump Sipi to 3.8.8 #2972

merged 1 commit into from
Dec 20, 2023

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Dec 20, 2023

Pull Request Checklist

Task Description/Number

Part of DEV-3022

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Dec 20, 2023

@subotic subotic self-assigned this Dec 20, 2023
@subotic subotic force-pushed the feature/dev-3022-bump-sipi branch from d723534 to 4afecce Compare December 20, 2023 13:31
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (7fe2770) 88.54%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ra/webapi/responders/admin/UsersResponderADM.scala 0.00% 1 Missing ⚠️
.../slice/admin/api/service/UsersADMRestService.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2972       +/-   ##
===========================================
+ Coverage   11.74%   88.54%   +76.79%     
===========================================
  Files         246      249        +3     
  Lines       22907    22917       +10     
===========================================
+ Hits         2690    20291    +17601     
+ Misses      20217     2626    -17591     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subotic subotic force-pushed the feature/dev-3022-bump-sipi branch from 4afecce to 7fe2770 Compare December 20, 2023 16:08
@subotic subotic merged commit 9a00c3f into main Dec 20, 2023
15 checks passed
@subotic subotic deleted the feature/dev-3022-bump-sipi branch December 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants