-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add http metrics to all search endpoints by migrating to tapir DEV-2936 #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
changed the title
feat: Migrate search by label endpoints to tapir
feat: Migrate all search endpoints to tapir
Dec 3, 2023
seakayone
force-pushed
the
feat/add-more-codecs
branch
from
December 3, 2023 13:09
b24ff6b
to
3f86148
Compare
seakayone
force-pushed
the
feat/add-more-codecs
branch
from
December 4, 2023 14:40
d03b032
to
80e7914
Compare
seakayone
requested review from
BalduinLandolt and
mpro7
and removed request for
BalduinLandolt
December 4, 2023 14:40
seakayone
changed the title
feat: Migrate all search endpoints to tapir
feat: Add metrics to all search endpoints by migrating to tapir DEV-2936
Dec 4, 2023
seakayone
changed the title
feat: Add metrics to all search endpoints by migrating to tapir DEV-2936
feat: Add http metrics to all search endpoints by migrating to tapir DEV-2936
Dec 4, 2023
BalduinLandolt
approved these changes
Dec 5, 2023
mpro7
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please find below two suggestions:
webapi/src/main/scala/org/knora/webapi/responders/v2/SearchResponderV2.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/search/api/SearchEndpoints.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?