Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add http metrics to all search endpoints by migrating to tapir DEV-2936 #2958

Merged
merged 12 commits into from
Dec 6, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Dec 3, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 399 lines in your changes are missing coverage. Please review.

Comparison is base (44e6bdc) 11.63% compared to head (d768db4) 11.62%.
Report is 8 commits behind head on main.

Files Patch % Lines
...nora/webapi/slice/search/api/SearchEndpoints.scala 0.00% 75 Missing ⚠️
...knora/webapi/messages/util/rdf/RdfFormatUtil.scala 15.58% 65 Missing ⚠️
...knora/webapi/responders/v2/SearchResponderV2.scala 0.00% 49 Missing ⚠️
...cala/org/knora/webapi/slice/common/api/ApiV2.scala 0.00% 46 Missing ⚠️
...org/knora/webapi/messages/util/rdf/JenaModel.scala 4.16% 23 Missing ⚠️
...c/main/scala/org/knora/webapi/OntologySchema.scala 25.00% 18 Missing ⚠️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 0.00% 17 Missing ⚠️
.../knora/webapi/slice/common/api/BaseEndpoints.scala 0.00% 17 Missing ⚠️
...rg/knora/webapi/messages/util/rdf/JsonLDUtil.scala 0.00% 12 Missing ⚠️
...plestore/upgrade/plugins/UpgradePluginPR1307.scala 0.00% 10 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
- Coverage   11.63%   11.62%   -0.01%     
==========================================
  Files         246      246              
  Lines       22880    22870      -10     
==========================================
- Hits         2661     2658       -3     
+ Misses      20219    20212       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title feat: Migrate search by label endpoints to tapir feat: Migrate all search endpoints to tapir Dec 3, 2023
@seakayone seakayone force-pushed the feat/add-more-codecs branch from b24ff6b to 3f86148 Compare December 3, 2023 13:09
@seakayone seakayone force-pushed the feat/add-more-codecs branch from d03b032 to 80e7914 Compare December 4, 2023 14:40
@seakayone seakayone requested review from BalduinLandolt and mpro7 and removed request for BalduinLandolt December 4, 2023 14:40
@seakayone seakayone marked this pull request as ready for review December 4, 2023 14:40
@seakayone seakayone changed the title feat: Migrate all search endpoints to tapir feat: Add metrics to all search endpoints by migrating to tapir DEV-2936 Dec 4, 2023
Copy link

linear bot commented Dec 4, 2023

@seakayone seakayone changed the title feat: Add metrics to all search endpoints by migrating to tapir DEV-2936 feat: Add http metrics to all search endpoints by migrating to tapir DEV-2936 Dec 4, 2023
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please find below two suggestions:

@seakayone seakayone enabled auto-merge (squash) December 6, 2023 16:13
@seakayone seakayone merged commit 20f8d5c into main Dec 6, 2023
14 checks passed
@seakayone seakayone deleted the feat/add-more-codecs branch December 6, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants