Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Sipi version to 3.8.7 #2951

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Nov 28, 2023

Pull Request Checklist

Task Description/Number

Part of DEV-2988

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Nov 28, 2023

DEV-2988 Improve SIPI crash detection and handling with sentry

  • use crashpad (out-of-process) crash handler instead of the current in-process crash handler
  • additionally add version of sipi to the sentry release tag and sipi binary

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44e6bdc) 11.63% compared to head (beeb3ec) 88.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2951       +/-   ##
===========================================
+ Coverage   11.63%   88.52%   +76.89%     
===========================================
  Files         246      246               
  Lines       22880    22880               
===========================================
+ Hits         2661    20255    +17594     
+ Misses      20219     2625    -17594     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subotic subotic self-assigned this Nov 28, 2023
@subotic subotic merged commit 5b3436b into main Nov 29, 2023
16 checks passed
@subotic subotic deleted the feature/dev-2988-improve-sipi-crash-detection-and-handling-with-sentry branch November 29, 2023 07:14
@subotic
Copy link
Collaborator Author

subotic commented Nov 29, 2023

@BalduinLandolt thanks! :-)

seakayone added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants