-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add http metrics for gravsearch endpoints (DEV-2936) #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvocation Introduces SchemaAndOptions because OntologySchema and SchemaOption are often passed in as parameters in tandem.
…http-metrics-for-search-endpoints
seakayone
changed the title
feat: Add http metrics for search endpoints (DEV-2936)
feat: Add http metrics for gravsearch endpoints (DEV-2936)
Dec 1, 2023
mpro7
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Please see my comments, suggestions below:
webapi/src/main/scala/org/knora/webapi/routing/v2/SearchRouteV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/common/api/ApiV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/common/api/ApiV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/common/api/ApiV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/search/api/SearchEndpoints.scala
Show resolved
Hide resolved
…2.scala Co-authored-by: Marcin Procyk <[email protected]>
…scala Co-authored-by: Marcin Procyk <[email protected]>
…scala Co-authored-by: Marcin Procyk <[email protected]>
BalduinLandolt
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seakayone
force-pushed
the
feat/add-http-metrics-for-search-endpoints
branch
4 times, most recently
from
December 4, 2023 11:12
9400083
to
5f91d01
Compare
mpro7
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Add additional metrics based on headers set from DSP-App to have a better visibility into the usage of the
/v2/searchextended
and/v2/searchextended/count
routes forGET
andPOST
http methods.Achieve this by migrating endpoints to Tapir.
KnoraResponseRenderer
, codecs and constants incommon.api
package.FormatOptions
tapir input representing the desired combination ofRdfFormat
,ApiV2Schema
andRendering
when rendering any rdf responsePR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?