Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release-please): Add missing PR title prefixes to the workflow #2918

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Nov 6, 2023

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

This PR just adds recently added perf prefix to release creation workflow and slightly updates PR template.

PR Type

  • chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents a new feature
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: all about tests: adding, refactoring tests (no production code change)

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 self-assigned this Nov 6, 2023
@mpro7 mpro7 marked this pull request as ready for review November 6, 2023 10:30
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e95d71) 11.68% compared to head (2b47e7b) 88.04%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2918       +/-   ##
===========================================
+ Coverage   11.68%   88.04%   +76.36%     
===========================================
  Files         251      251               
  Lines       23065    23068        +3     
===========================================
+ Hits         2695    20311    +17616     
+ Misses      20370     2757    -17613     
Files Coverage Δ
...bapi/src/main/scala/dsp/valueobjects/Project.scala 97.59% <100.00%> (+11.17%) ⬆️
.../slice/admin/domain/service/KnoraProjectRepo.scala 100.00% <100.00%> (ø)
...slice/admin/domain/service/ProjectADMService.scala 97.77% <100.00%> (+86.41%) ⬆️
...ce/admin/domain/service/ProjectExportService.scala 63.23% <100.00%> (+63.23%) ⬆️
...lice/admin/repo/service/KnoraProjectRepoLive.scala 96.96% <100.00%> (+96.96%) ⬆️

... and 199 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 enabled auto-merge (squash) November 7, 2023 09:00
@mpro7 mpro7 disabled auto-merge November 7, 2023 09:09
@mpro7
Copy link
Contributor Author

mpro7 commented Nov 7, 2023

I just moved perf to Enhancements section instead Maintenance, which IMO makes more sense.

@mpro7 mpro7 merged commit 142fee0 into main Nov 7, 2023
14 checks passed
@mpro7 mpro7 deleted the update-create-release branch November 7, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants