Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return permissions and do not throw exception for FileValues with more than one version (DEV-2855) #2894

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Oct 23, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2855

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone marked this pull request as ready for review October 23, 2023 07:41
@seakayone seakayone changed the title fix: Return permissions and do not throw exception for FileValues with more than one version fix: Return permissions and do not throw exception for FileValues with more than one version (DEV-2855) Oct 23, 2023
@linear
Copy link

linear bot commented Oct 23, 2023

DEV-2855 scenario-tanner - error on images (404)

Screenshot 2023-10-20 at 13.44.28.png

All images get a 404 error on PROD, 500 knora.json OK on the snackbar. The PI of the project reported the problem as well at 7:36am on October 20th.

Project scenario-tanner 0102.

Permissions have been modified.

After some checks On October 20th, only the project scenario-tanner is impacted, but all images are affected...

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (cbb1630) 24.38%.
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2894      +/-   ##
==========================================
+ Coverage   18.00%   24.38%   +6.38%     
==========================================
  Files         281      251      -30     
  Lines       28899    23071    -5828     
==========================================
+ Hits         5202     5625     +423     
+ Misses      23697    17446    -6251     

see 208 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone enabled auto-merge (squash) October 23, 2023 07:49
@seakayone seakayone merged commit 2b0952e into main Oct 23, 2023
19 checks passed
@seakayone seakayone deleted the fix/permission-check-fails-on-multiple-file-values branch October 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants