Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR template #2878

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: update PR template #2878

merged 2 commits into from
Oct 12, 2023

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Oct 12, 2023

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

Because we tend to forget to tick the bottom fields if empty anyway, I just removed them. Now is a bit less to scroll.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@mpro7 mpro7 self-assigned this Oct 12, 2023
@mpro7 mpro7 marked this pull request as ready for review October 12, 2023 10:42
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (4af2ac9) 88.15%.
Report is 85 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2878       +/-   ##
===========================================
+ Coverage   18.00%   88.15%   +70.15%     
===========================================
  Files         281      250       -31     
  Lines       28899    23252     -5647     
===========================================
+ Hits         5202    20497    +15295     
+ Misses      23697     2755    -20942     

see 237 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 merged commit 6c04101 into main Oct 12, 2023
@mpro7 mpro7 deleted the pr-template-update branch October 12, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants