-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): Set container memory limits in local stack (DEV-2718) #2874
chore(docker): Set container memory limits in local stack (DEV-2718) #2874
Conversation
DEV-2718 triplestore killed when creating project or uploading data with DSP-TOOLS
Since some days, several RDU members have this problem, on several machines, always on localhost: When creating a big project from a JSON file, or when uploading a big XML file, the triplestore suddenly becomes unresponsive. Sometimes it happens already during project creation, sometimes during the xmlupload. See the attached logs of the respective docker containers: The triplestore says it was killed:
(but the docker "db" container is still running) Steps to reproduce:
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
===========================================
+ Coverage 18.00% 88.12% +70.12%
===========================================
Files 281 254 -27
Lines 28899 23281 -5618
===========================================
+ Hits 5202 20517 +15315
+ Misses 23697 2764 -20933 ☔ View full report in Codecov by Sentry. |
We could probably lower the limits, but for now I've just picked values such that the entire stack should use at most around 20GB memory. |
@SamuelBoerlin thanks for this approach. I think it really makes sense to limit the resources of each container so that we get a better feedback if one of the services is running out of memory. The chosen defaults make sense in the beginning. We can optimise them in the long run. Maybe it makes sense to mention the total memory needed in our documentation about the local dev env setup |
Sure, makes sense. I'll add it. |
Added documentation |
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?