-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate secure admin/projects endpoints to Tapir DEV-2806 #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate all public ProjectEndpoints to Tapir
seakayone
changed the title
Refactor/add secure endpoints
refactor: Migrate secure admin/projects endpoints to Tapir
Oct 6, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
==========================================
+ Coverage 18.00% 23.23% +5.23%
==========================================
Files 281 250 -31
Lines 28899 23252 -5647
==========================================
+ Hits 5202 5402 +200
+ Misses 23697 17850 -5847 ☔ View full report in Codecov by Sentry. |
seakayone
requested review from
mpro7 and
BalduinLandolt
and removed request for
mpro7
October 10, 2023 15:34
BalduinLandolt
approved these changes
Oct 11, 2023
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsPayloadsADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/BaseEndpoints.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/ProjectsEndpointsHandlerF.scala
Outdated
Show resolved
Hide resolved
seakayone
commented
Oct 11, 2023
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsPayloadsADM.scala
Outdated
Show resolved
Hide resolved
mpro7
approved these changes
Oct 11, 2023
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsPayloadsADM.scala
Outdated
Show resolved
Hide resolved
seakayone
changed the title
refactor: Migrate secure admin/projects endpoints to Tapir
refactor: Migrate secure admin/projects endpoints to Tapir DEV-2806
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
/admin/projects/*
endpoints do not support providing credentials/tokens in the URL)Does this PR change client-test-data?