Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate secure admin/projects endpoints to Tapir DEV-2806 #2872

Merged
merged 36 commits into from
Oct 12, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Oct 6, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes (/admin/projects/* endpoints do not support providing credentials/tokens in the URL)
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone changed the title Refactor/add secure endpoints refactor: Migrate secure admin/projects endpoints to Tapir Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (1759a94) 23.23%.
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   18.00%   23.23%   +5.23%     
==========================================
  Files         281      250      -31     
  Lines       28899    23252    -5647     
==========================================
+ Hits         5202     5402     +200     
+ Misses      23697    17850    -5847     

see 182 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone requested review from mpro7 and BalduinLandolt and removed request for mpro7 October 10, 2023 15:34
@seakayone seakayone self-assigned this Oct 10, 2023
@seakayone seakayone requested a review from mpro7 October 11, 2023 06:05
@seakayone seakayone marked this pull request as ready for review October 11, 2023 06:05
Base automatically changed from chore/add-tapir-dependencies to main October 11, 2023 14:23
@seakayone seakayone merged commit 9f98f7e into main Oct 12, 2023
13 of 14 checks passed
@seakayone seakayone deleted the refactor/add-secure-endpoints branch October 12, 2023 09:49
@seakayone seakayone changed the title refactor: Migrate secure admin/projects endpoints to Tapir refactor: Migrate secure admin/projects endpoints to Tapir DEV-2806 Oct 13, 2023
@linear
Copy link

linear bot commented Oct 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants