Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Configure Scala Steward to produce PR with compatible title #2867

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Oct 2, 2023

https://github.com/scala-steward-org/scala-steward/blob/main/docs/repo-specific-configuration.md

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@seakayone seakayone marked this pull request as ready for review October 2, 2023 08:59
@seakayone seakayone enabled auto-merge (squash) October 2, 2023 08:59
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (e8c019f) 88.05%.
Report is 77 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2867       +/-   ##
===========================================
+ Coverage   18.00%   88.05%   +70.05%     
===========================================
  Files         281      244       -37     
  Lines       28899    23123     -5776     
===========================================
+ Hits         5202    20362    +15160     
+ Misses      23697     2761    -20936     

see 229 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone merged commit fbbe5ec into main Oct 2, 2023
14 checks passed
@seakayone seakayone deleted the chore/update-scala-steward-commit-message branch October 2, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants